[Openmp-commits] [PATCH] D137774: [openmp] Create a local llvm-lit script when building openmp standalone

Martin Storsjö via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Nov 10 01:57:20 PST 2022


mstorsjo created this revision.
mstorsjo added reviewers: AndreyChurbanov, JonChesterfield, natgla, jdoerfert.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a subscriber: sstefan1.
Herald added a project: OpenMP.

Check whether the main llvm directory exists adjacent to the
openmp directory (when building from the monorepo, this is always
the case; if building from a separate tarball it won't be found).

If found, include the AddLLVM cmake module, which contains
functions such as add_lit_testsuite.

Use add_lit_testsuite instead of add_custom_target, and
configure_lit_site_cfg instead of the plain configure_file,
if available.

By using configure_lit_site_cfg, it includes lit.site.cfg in the
generated llvm-lit script, which allows pointing llvm-lit directly
at individual tests, instead of needing to point it at the generated
test directory in the build directory (where one can't easily run
individual tests).

This allows investigating and rerunning individual tests without
needing to run the full testsuite via "check-openmp".

This is similar to what other runtime subprojects such as libcxx
did (before libcxx entirely removed support for building standalone).
If openmp is built via the main llvm-project/runtimes directory,
that directory provides the llvm-lit script.

If building outside of the main llvm build, it's still necessary
to provide the FileCheck and "not" executables for running the
tests though.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D137774

Files:
  openmp/CMakeLists.txt
  openmp/cmake/OpenMPTesting.cmake
  openmp/runtime/test/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137774.474480.patch
Type: text/x-patch
Size: 5837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20221110/6ce08cf3/attachment.bin>


More information about the Openmp-commits mailing list