[Openmp-commits] [PATCH] D137168: [OpenMP][mingw] Fix build for aarch64 target

Tue Nov 8 05:05:40 PST 2022

mstorsjo added a comment.

In D137168#3912206 <https://reviews.llvm.org/D137168#3912206>, @natgla wrote:

>> I've finally managed to somehow cobble things together so I can run the lit tests for this configuration: it mostly seems to work, but there are a couple failures that I probably should look into (although I don't know if they're related to what's being changed here or whether it's a later issue.
>>
>> Anyway, with x86_64 clang-cl/msvc mode, there's 4 legitimate test failures among the tests; with x86_64 mingw there's those 4 plus yet another one failing. With aarch64 mingw there's 9 more failing tests (but still 180 tests passing).
>
> We never tested this configuration. I'd suggest to look at the additional failures, and if they are related to atomics, to investigate them (otherwise consider them to be a different issue). If you can share all logs, I'd be curious to look at the results too (it won't save you any time though)

I managed to sort out all the test failures - many of them were caused by using slight mismatches in version between the sources to build libomp.dll and for running tests, some caused by using a slightly older version of clang to build.

I'll go ahead and push this one then, and send patches for other issues I've sorted out. I'll be happy to CC you on those patches too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137168/new/

https://reviews.llvm.org/D137168