[Openmp-commits] [PATCH] D137168: [OpenMP][mingw] Fix build for aarch64 target

Fri Nov 4 15:33:17 PDT 2022

mstorsjo added a comment.

In D137168#3903678 <https://reviews.llvm.org/D137168#3903678>, @mstorsjo wrote:

> In D137168#3903641 <https://reviews.llvm.org/D137168#3903641>, @natgla wrote:
>
>> In D137168#3900133 <https://reviews.llvm.org/D137168#3900133>, @mstorsjo wrote:
>>
>>> FWIW I tested this patch for a mingw/aarch64 environment, and at least a very small testcase does seem to run as expected.
>>
>> Did you try more tests, with different atomic pragmas?
>
> Not yet; I’m working on setting up so I can run the lit tests (`check-openmp`) though.

I've finally managed to somehow cobble things together so I can run the lit tests for this configuration: it mostly seems to work, but there are a couple failures that I probably should look into (although I don't know if they're related to what's being changed here or whether it's a later issue.

Anyway, with x86_64 clang-cl/msvc mode, there's 4 legitimate test failures among the tests; with x86_64 mingw there's those 4 plus yet another one failing. With aarch64 mingw there's 9 more failing tests (but still 180 tests passing).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137168/new/

https://reviews.llvm.org/D137168