[Openmp-commits] [PATCH] D128403: [OpenMP] add 4 custom APIs supporting MSVC OMP codegen

[Jonathan Peyton via Phabricator via Openmp-commits]

jlpeyton added a comment.

Hi Vadim!

Can you add maximum amount of context to patches: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

> To get a full diff, use one of the following commands
>
> - git show HEAD -U999999 > mypatch.patch
> - git diff -U999999 u <https://reviews.llvm.org/diviner/find/?name=u&type=null&jump=1> > mypatch.patch
> - git diff HEAD~1 -U999999 > mypatch.patch





================
Comment at: openmp/runtime/src/kmp_dispatch.cpp:2288
 
+*!
+ at ingroup WORK_SHARING
----------------
Need this to be /*!


================
Comment at: openmp/runtime/src/kmp_dispatch.cpp:2400
+  kmp_info_t *th = __kmp_threads[gtid];
+  kmp_team_t *team = th->th.th_team;
+
----------------
This comes up as unused because it is only in `KMP_DEBUG_ASSERT()` macros. Can you either change the `team` usages to `th->th.th_team` in the `KMP_DEBUG_ASSERT()` or have
```
#ifdef KMP_DEBUG
kmp_team_t *team = th->th.th_team;
#endif 
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128403/new/

https://reviews.llvm.org/D128403