[Openmp-commits] [PATCH] D128347: [OpenMP] Implementing omp_get_device_num()
Shilei Tian via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Wed Jun 22 09:30:00 PDT 2022
tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.
LGTM with one code style issue.
================
Comment at: openmp/libomptarget/src/api.cpp:39
+
+ return hostDevice;
+}
----------------
`HostDevice` should be the LLVM style variable name.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128347/new/
https://reviews.llvm.org/D128347
More information about the Openmp-commits
mailing list