[Openmp-commits] [PATCH] D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info

Saiyedul Islam via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jun 14 10:41:10 PDT 2022


saiislam created this revision.
saiislam added reviewers: jdoerfert, JonChesterfield, jhuber6, yaxunl.
Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, jvesely, kzhuravl.
Herald added a project: All.
saiislam requested review of this revision.
Herald added subscribers: openmp-commits, wdng.
Herald added a project: OpenMP.

This patch extends the is_valid_binary routine to also check if the
binary's target ID matches the one parsed from the system's runtime
environment.
This should allow us to only use the binary whose compute capability
matches, allowing us to support basic multi-architecture binaries for
AMDGPU.
It also handles compatibility testing of target IDs of the image and
the enviornment.

Depends on D127432 <https://reviews.llvm.org/D127432>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127769

Files:
  openmp/libomptarget/plugins/amdgpu/dynamic_hsa/hsa.h
  openmp/libomptarget/plugins/amdgpu/src/rtl.cpp
  openmp/libomptarget/plugins/exports

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127769.436851.patch
Type: text/x-patch
Size: 6839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20220614/d066e4d7/attachment-0001.bin>


More information about the Openmp-commits mailing list