[Openmp-commits] [PATCH] D127432: [Libomptarget] Add support for offloading binaries in libomptarget

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jun 10 12:18:38 PDT 2022


jhuber6 updated this revision to Diff 436009.
jhuber6 added a comment.

Chaning to use an additional struct instead. Also implemented the class to parse these.

Let me know if there are runtime considerations here, with the unique pointer allocations and string conversions for the map. The usage of `__tgt_is_valid_binary` is supposed to be mostly lightweight without invoking the runtime, so let me know if this is too expensive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127432/new/

https://reviews.llvm.org/D127432

Files:
  openmp/libomptarget/include/OffloadBinary.h
  openmp/libomptarget/include/device.h
  openmp/libomptarget/include/omptarget.h
  openmp/libomptarget/include/omptargetplugin.h
  openmp/libomptarget/include/rtl.h
  openmp/libomptarget/plugins/amdgpu/src/rtl.cpp
  openmp/libomptarget/plugins/cuda/src/rtl.cpp
  openmp/libomptarget/plugins/generic-elf-64bit/src/rtl.cpp
  openmp/libomptarget/plugins/remote/src/rtl.cpp
  openmp/libomptarget/plugins/ve/src/rtl.cpp
  openmp/libomptarget/src/rtl.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127432.436009.patch
Type: text/x-patch
Size: 12226 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20220610/5b877acc/attachment.bin>


More information about the Openmp-commits mailing list