[Openmp-commits] [PATCH] D127505: [Libomptarget] Add checks for CUDA subarchitecture using new info

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

In D127505#3573731 <https://reviews.llvm.org/D127505#3573731>, @jhuber6 wrote:

> In D127505#3573729 <https://reviews.llvm.org/D127505#3573729>, @tianshilei1992 wrote:
>
>> In D127505#3573696 <https://reviews.llvm.org/D127505#3573696>, @jhuber6 wrote:
>>
>>> Should I add a test for this? Something like
>>>
>>>   clang --offload-arch=sm_35 --offload-arch=sm_37 --offload-arch=sm_50 --offload-arch=sm_52 --offload-arch=sm_53 --offload-arch=sm_60 --offload-arch=sm_61 --offload-arch=sm_62 --offload-arch=sm_70 --offload-arch=sm_72 --offload-arch=sm_75 --offload-arch=sm_80 --offload-arch=sm_86
>>
>> I don't think our current runtime libraries support the case that there are multiple images for one plugin.
>
> That's the whole point of this patch set. Now we will embed all of these images into an offloading binary which contains the architecture string. Inside the runtime we can then check if the architecture string matches and use that if it matches.

Oh, sorry didnt see its parent patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127505/new/

https://reviews.llvm.org/D127505