[Openmp-commits] [PATCH] D127432: [Libomptarget] Add support for offloading binaries in libomptarget

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jun 10 09:14:44 PDT 2022


jhuber6 added a comment.

Instead of changing the `__tgt_device_image`, do you think it would be better to just to make a new type that only contains the extracted metadata? We could just pass a pointer to the into struct to the `is_valid_binary`, might be much cleaner. Then we would make a new `__tgt_device_image` that points to the actual ELF and use that as we do currently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127432/new/

https://reviews.llvm.org/D127432



More information about the Openmp-commits mailing list