[Openmp-commits] [PATCH] D127505: [Libomptarget] Add checks for CUDA subarchitecture using new info

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

Should I add a test for this? Something like

  clang --offload-arch=sm_35 --offload-arch=sm_37 --offload-arch=sm_50 --offload-arch=sm_52 --offload-arch=sm_53 --offload-arch=sm_60 --offload-arch=sm_61 --offload-arch=sm_62 --offload-arch=sm_70 --offload-arch=sm_72 --offload-arch=sm_75 --offload-arch=sm_80 --offload-arch=sm_86



================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:1518
+    if (ArchStr == image->Info.Arch)
+      return true;
+  }
----------------
tianshilei1992 wrote:
> I think here we should check if all devices are compatible instead of one.
> ```
>   if (ArchStr != image->Info.Arch)
>     return true;
> }
> 
> return true.
> ```
Yeah I wasn't sure how to handle this in the case of multiple devices, but it's probably more reasonable to expect each one to match the architecture for it to be compatible. I'll change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127505/new/

https://reviews.llvm.org/D127505