[Openmp-commits] [PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

[Sebastian Neubauer via Phabricator via Openmp-commits]

sebastian-ne added inline comments.


================
Comment at: openmp/runtime/src/CMakeLists.txt:383
         \"${alias}${LIBOMP_LIBRARY_SUFFIX}\" WORKING_DIRECTORY
-        \"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${OPENMP_INSTALL_LIBDIR}\")")
+        \"\$ENV{DESTDIR}\${outdir}\")")
     endforeach()
----------------
The backslash before `\${outdir}` is wrong here, it must be `\"\$ENV{DESTDIR}${outdir}\")")`.

Also, before this patch, there were a lot of backslashes before e.g. `\${CMAKE_INSTALL_PREFIX}`, but I hope that shouldn’t matter, the value should be the same at configure and install time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130545/new/

https://reviews.llvm.org/D130545