[Openmp-commits] [PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

[John Ericson via Phabricator via Openmp-commits]

Ericson2314 added inline comments.


================
Comment at: openmp/CMakeLists.txt:3
 
-# Add cmake directory to search for custom cmake functions.
-set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake ${CMAKE_MODULE_PATH})
+set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)
+
----------------
sebastian-ne wrote:
> There are some places that surround this by an `if(NOT DEFINED LLVM_COMMON_CMAKE_UTILS)` (e.g. lldb/cmake/modules/LLDBStandalone.cmake, clang/CMakeLists.txt, polly/CMakeLists.txt) although other places don’t (lld/CMakeLists.txt, libunwind/CMakeLists.txt, etc.), so both seem to be fine.
Ah true. Yeah it should be fine either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130545/new/

https://reviews.llvm.org/D130545