[Openmp-commits] [PATCH] D130298: [Libomptarget] Only export needed definitions in the BC library

Thu Jul 21 14:56:06 PDT 2022

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

In D130298#3669776 <https://reviews.llvm.org/D130298#3669776>, @jhuber6 wrote:

> In D130298#3669752 <https://reviews.llvm.org/D130298#3669752>, @jdoerfert wrote:
>
>> can't we do __kmpc* and omp_* and llvm_* instead?
>
> The `internalize` patch just takes full names. It would definitely be better to use wildcards. I could set up a patch to make it accept those as well, but it would take some extra time to get reviewed.

Add a TODO somewhere. LG Otherwise

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130298/new/

https://reviews.llvm.org/D130298