[Openmp-commits] [PATCH] D130262: [Libomptarget] Make the plugins link as LLVM libraries

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jul 21 07:59:37 PDT 2022

tianshilei1992 added inline comments.

Comment at: openmp/libomptarget/plugins/ve/CMakeLists.txt:43
+  )
jhuber6 wrote:
> tianshilei1992 wrote:
> > jhuber6 wrote:
> > > tianshilei1992 wrote:
> > > > why do we need `NO_INSTALL_RPATH` here but later set its property separately?
> > > I'm not exactly sure, that was a configuration the AMD people gave me that finally made it stop breaking on their CI system. I think we need to manually set it to the libomptarget install as well whereas that one would set it to the one that goes in `/build/lib`. Ideally in the future we'd just put everything in the same library instead of duplicating it, but getting these configurations right is pretty finicky.
> > That doesn't look good. Is there any argument provided by `add_llvm_library` could do something similar, instead of having completely contrary setting?
> Not sure, I think the `NO_INSTALL_RPATH` only applies to the one installed under the `/lib` directory and not the one we manually install. it worked on my machine without the rpath / installation business but the only buildbot we have didn't like it. If I had access to the machine I could try to figure it out but I'm not really interested in pushing and reverting commits until it's happy.
The script used by those systems are available right?

  rG LLVM Github Monorepo



More information about the Openmp-commits mailing list