[Openmp-commits] [PATCH] D130266: [Libomptarget] Build the device library even if the sm list is empty

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

In D130266#3668798 <https://reviews.llvm.org/D130266#3668798>, @jhuber6 wrote:

> In D130266#3668795 <https://reviews.llvm.org/D130266#3668795>, @tianshilei1992 wrote:
>
>> Does it affect the option that we can build bc lib for one arch but not for another, like I just would like to build AMD bc lib? We can't assume the LLVM/Clang used for the compilation supports all arch.
>
> If the lists are empty, the for loops setting the architecture won't generate any code right. For the static library it won't get embedded in the binary either.

Right. The logic here is a little messy because contains some inconsistency when we implemented `DeviceRTL` first for NVPTX and later for AMDGPU.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130266/new/

https://reviews.llvm.org/D130266