[Openmp-commits] [PATCH] D130262: [Libomptarget] Make the plugins link as LLVM libraries

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/plugins/ve/CMakeLists.txt:43
+
+    NO_INSTALL_RPATH
+  )
----------------
tianshilei1992 wrote:
> why do we need `NO_INSTALL_RPATH` here but later set its property separately?
I'm not exactly sure, that was a configuration the AMD people gave me that finally made it stop breaking on their CI system. I think we need to manually set it to the libomptarget install as well whereas that one would set it to the one that goes in `/build/lib`. Ideally in the future we'd just put everything in the same library instead of duplicating it, but getting these configurations right is pretty finicky.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130262/new/

https://reviews.llvm.org/D130262