[Openmp-commits] [PATCH] D130165: Validate python packages availability before building ompd gdb-plugin code

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

An alternative approach would be to install the python modules wheels and setuptools into the build directory using pip instead of bailing out.



================
Comment at: openmp/libompd/CMakeLists.txt:64
+      endif()
+      string(FIND ${PIP3_SHOW_INFO} "not found" WHEEL_FOUND)
+      if(NOT WHEEL_FOUND EQUAL -1)
----------------
I'm afraid, this will break if locale is not English.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130165/new/

https://reviews.llvm.org/D130165