[Openmp-commits] [PATCH] D130030: [OpenMP][DeviceRTL] Remove `atomic::store`

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 19 16:36:06 PDT 2022


tianshilei1992 added a comment.

In D130030#3663558 <https://reviews.llvm.org/D130030#3663558>, @jdoerfert wrote:

> No, this is strictly worse. If anything, we can introduce a switch to ensure the ordering is known statically. We can use a macro and do it for all of the atomic ops.

It doesn't work because `__atomic_exchange_n` with `__ATOMIC_RELEASE` will be lowered to `atomicLoad`, which again causes the issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130030/new/

https://reviews.llvm.org/D130030



More information about the Openmp-commits mailing list