[Openmp-commits] [PATCH] D129875: [Libomptarget] Make libomptarget an LLVM library

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

In D129875#3656522 <https://reviews.llvm.org/D129875#3656522>, @ye-luo wrote:

> In D129875#3656431 <https://reviews.llvm.org/D129875#3656431>, @jhuber6 wrote:
>
>> In D129875#3656403 <https://reviews.llvm.org/D129875#3656403>, @ye-luo wrote:
>>
>>> Prefer additional dependency remains optional.
>>
>> The only downsides I see from this approach is that user code will depend on LLVM libraries if LLVM is build using shared libraries. But I'm pretty sure the default build method in LLVM is to use static libraries so that shouldn't propagate to users just wishing to build `libomptarget` alone. We may have some vendors complain about the extra dependency, but I'm personally not aware of anyone using Clang/LLVM for OpenMP offloading that isn't building it with LLVM or getting it through a release that was build with LLVM.
>
> That is exactly my concern. Won't be happy to see llvm libraries on the application side. If it is internal to the libomptarget, that is fine. It seems all the llvm libraries are static in my builds. Then it is likely OK.

If you want to make extra sure you can apply this patch and use the new clang to compile any offloading application. Run `ldd` on it and see if there are any LLVM libraries listed in the dependencies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129875/new/

https://reviews.llvm.org/D129875