[Openmp-commits] [PATCH] D129896: [Libomptarget] Fix warnings on address space attributes

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jul 15 14:21:41 PDT 2022


This revision was automatically updated to reflect the committed changes.
Closed by commit rGcdea43705721: [Libomptarget] Fix warnings on address space attributes (authored by jhuber6).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129896/new/

https://reviews.llvm.org/D129896

Files:
  openmp/libomptarget/DeviceRTL/include/Types.h


Index: openmp/libomptarget/DeviceRTL/include/Types.h
===================================================================
--- openmp/libomptarget/DeviceRTL/include/Types.h
+++ openmp/libomptarget/DeviceRTL/include/Types.h
@@ -202,12 +202,12 @@
 // TODO: clang should use address space 5 for omp_thread_mem_alloc, but right
 //       now that's not the case.
 #define THREAD_LOCAL(NAME)                                                     \
-  NAME [[clang::loader_uninitialized, clang::address_space(5)]]
+  [[clang::address_space(5)]] NAME [[clang::loader_uninitialized]]
 
 // TODO: clang should use address space 4 for omp_const_mem_alloc, maybe it
 //       does?
 #define CONSTANT(NAME)                                                         \
-  NAME [[clang::loader_uninitialized, clang::address_space(4)]]
+  [[clang::address_space(4)]] NAME [[clang::loader_uninitialized]]
 
 // Attribute to keep alive certain definition for the bitcode library.
 #ifdef LIBOMPTARGET_BC_TARGET


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129896.445133.patch
Type: text/x-patch
Size: 987 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20220715/c6815912/attachment.bin>


More information about the Openmp-commits mailing list