[Openmp-commits] [PATCH] D129787: [OpenMP][AMDGPU] Add the support for `malloc` and `free` for AMDGPU

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 planned changes to this revision.
tianshilei1992 added a comment.

It looks like there are a couple of things still missing:

- `malloc` and `free` defined for AMDGPU using `declare variant` cannot be linked into the device module correctly. Their names still contain declare variant mangling such that they are dropped directly, leaving `malloc` and `free` still undefined.
- Even manually link the functions into device module, because some host setup are missing, as Jon pointed out, there is still runtime error "HSA_STATUS_ERROR_MEMORY_FAULT: Agent attempted to access an inaccessible address.".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129787/new/

https://reviews.llvm.org/D129787