[Openmp-commits] [PATCH] D129787: [OpenMP][AMDGPU] Add the support for `malloc` and `free` for AMDGPU

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 marked 2 inline comments as done.
tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/DeviceRTL/src/Memory.cpp:31
+
+#pragma omp end declare variant
+///}
----------------
jdoerfert wrote:
> I think we want (now or later) a second level of indirection here.
> malloc -> _OMP::impl::malloc -> (__ockl_dm_alloc, ...)
> 
> Also, we need to annotate all external functions properly, e.g., see malloc and free in State.cpp.
> Finally, combine this with existing malloc/free declarations and uses in the runtime.
That would be our next step after we have a proper allocator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129787/new/

https://reviews.llvm.org/D129787