[Openmp-commits] [PATCH] D127399: [OpenMP] Ensure createXXX functions will always call updateToLocation

[Michael Kruse via Phabricator via Openmp-commits]

Meinersbur added a comment.

In D127399#3636469 <https://reviews.llvm.org/D127399#3636469>, @jdoerfert wrote:

>   if (!CGF.HaveInsertPoint())                                                                                                                                                                                                                              
>      return;
>
> appears 35 times in CGOpenMPRuntime.cpp

Commenting them all out still passes all tests. It essentially dead/untested code. Also seen in the code coverage: https://lab.llvm.org/coverage/coverage-reports/coverage/Users/buildslave/jenkins/workspace/coverage/llvm-project/clang/lib/CodeGen/CGOpenMPRuntime.cpp.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127399/new/

https://reviews.llvm.org/D127399