[Openmp-commits] [PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

Dhruva Chakrabarti via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jul 8 17:06:36 PDT 2022

dhruvachak added a comment.

In D102107#3639735 <https://reviews.llvm.org/D102107#3639735>, @jdoerfert wrote:

> F23722893: ast_dump_2_check.py <https://reviews.llvm.org/F23722893>>>! In D102107#3639615 <https://reviews.llvm.org/D102107#3639615>, @dhruvachak wrote:
>> In D102107#3639556 <https://reviews.llvm.org/D102107#3639556>, @jdoerfert wrote:
>>> In D102107#3639551 <https://reviews.llvm.org/D102107#3639551>, @dhruvachak wrote:
>>>> Is there an llvm/utils script to update clang tests that have RUN lines at the top? An example is clang/test/OpenMP/debug_threadprivate_copyin.c.
>>> You can create the run lines with the `llvm/utils/update_cc_test_checks.py` script but those tests have manual lines for now.
>>> I usually run `llvm/utils/update_cc_test_checks.py -u clang/test/OpenMP/*.{c,cpp}` to update all autogenerated tests.
>> Okay, I will convert those few manual OpenMP tests to autogen format.
>> How about the AST ones? Do they have to be manually updated? Example: clang/test/AST/ast-dump-openmp-distribute-parallel-for-simd.c
> For these ones I have a script locally (attached) that need some manual doing but it helps:
>   1. run the ast dump and store the result (same as RUN line), e.g.,
>     {F23722650} clang -cc1 -internal-isystem /data/build/llvm-project/lib/clang/13.0.0/include -nostdsysteminc -triple x86_64-unknown-unknown -fopenmp -verify -ast-dump /data/src/llvm-project/clang/test/AST/ast-dump-openmp-begin-declare-variant_template_4.cpp &> /tmp/ast
>   2. python3 ast_dump_2_check.py /tmp/ast CHECK
>   3. replace the check lines with the content of /tmp/ast.check

Thanks. I followed the above steps and regenerated a couple of the AST tests but they still fail. Perhaps I am missing some options?

I currently have a handful of clang test failures where regen did not work. I am going to update the patch, post the current test results, and we can figure out how to regen the rest before we land this patch.

  rG LLVM Github Monorepo



More information about the Openmp-commits mailing list