[Openmp-commits] [PATCH] D128817: [Libomptarget] Use new tripcount argument in the runtime.

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/interface.cpp:385
+    PM->TblMapMtx.unlock();
+  }
+
----------------
jhuber6 wrote:
> jdoerfert wrote:
> > Doesn't `target` already do this? And we should get rid of this in a follow up.
> Oh yeah, I did it here and forgot to delete it after I decided to move it. I'll get rid of it. And why do we get rid of it in a follow-up?
we don't need this mutex and stuff anymore. Now the information is passed right into the target launch and not separately. See below.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:1556
                                  TgtArgs.size(), TeamNum, ThreadLimit,
                                  getLoopTripCount(DeviceId), AsyncInfo);
     else
----------------
And then delete everything that has to do with Device.LoopTripCnt


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128817/new/

https://reviews.llvm.org/D128817