[Openmp-commits] [PATCH] D127399: [OpenMP] Ensure createXXX functions will always call updateToLocation

[Michael Kruse via Phabricator via Openmp-commits]

Meinersbur added a comment.

In D127399#3636310 <https://reviews.llvm.org/D127399#3636310>, @jdoerfert wrote:

> Because that is the clang pattern and we want/need to be compatible.

Clang does not use such a pattern. When IRBuilder creates an instruction without an insert position, it still creates the instruction, but does not insert it into a function. `createCanonicalLoop` was supposed to do something similar (create the loop, but do not connect it to the CFG).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127399/new/

https://reviews.llvm.org/D127399