[Openmp-commits] [PATCH] D128997: [Libomptarget][NFC] Make Libomptarget use the LLVM naming convention

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/include/omptarget.h:207
 int omp_get_initial_device(void);
-void *omp_target_alloc(size_t size, int device_num);
-void omp_target_free(void *device_ptr, int device_num);
-int omp_target_is_present(const void *ptr, int device_num);
-int omp_target_memcpy(void *dst, const void *src, size_t length,
-                      size_t dst_offset, size_t src_offset, int dst_device,
-                      int src_device);
-int omp_target_memcpy_rect(void *dst, const void *src, size_t element_size,
-                           int num_dims, const size_t *volume,
-                           const size_t *dst_offsets, const size_t *src_offsets,
-                           const size_t *dst_dimensions,
-                           const size_t *src_dimensions, int dst_device,
-                           int src_device);
-int omp_target_associate_ptr(const void *host_ptr, const void *device_ptr,
-                             size_t size, size_t device_offset, int device_num);
-int omp_target_disassociate_ptr(const void *host_ptr, int device_num);
+void *omp_target_alloc(size_t Size, int DeviceNum);
+void omp_target_free(void *DevicePtr, int DeviceNum);
----------------
tianshilei1992 wrote:
> we probably keep those C APIs unchanged as the API names already don't follow LLVM standard.
Yes, I was somewhat careful to avoid renaming anything that was used outside of `libomptarget`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128997/new/

https://reviews.llvm.org/D128997