[Openmp-commits] [PATCH] D118637: [Libomptarget] Run GPU offloading tests using the new driver

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

Looks good. We can land this and revert with greater knowledge if the amdgpu buildbot fails on it.



================
Comment at: openmp/libomptarget/CMakeLists.txt:40
 set (LIBOMPTARGET_ALL_TARGETS "${LIBOMPTARGET_ALL_TARGETS} aarch64-unknown-linux-gnu")
 set (LIBOMPTARGET_ALL_TARGETS "${LIBOMPTARGET_ALL_TARGETS} amdgcn-amd-amdhsa")
 set (LIBOMPTARGET_ALL_TARGETS "${LIBOMPTARGET_ALL_TARGETS} amdgcn-amd-amdhsa-newRTL")
----------------
Could drop the amdgcn-amd-amdhsa and nvptx64-nvidia-cuda lines in passing, I should have removed them previously. Or leave them and we'll remove the -newRTL ones instead of renaming them.


================
Comment at: openmp/libomptarget/test/lit.cfg:121
         return name
 
 # substitutions
----------------
LG. We should drop this newRTL thing at some point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118637/new/

https://reviews.llvm.org/D118637