[Openmp-commits] [PATCH] D118493: Set rpath on openmp executables

Mon Jan 31 10:41:51 PST 2022

JonChesterfield added a comment.

In D118493#3284781 <https://reviews.llvm.org/D118493#3284781>, @thakis wrote:

> In D118493#3284663 <https://reviews.llvm.org/D118493#3284663>, @JonChesterfield wrote:
>
>> In D118493#3284617 <https://reviews.llvm.org/D118493#3284617>, @thakis wrote:
>>
>>> looks like the mac linker doesn't like this test either: http://45.33.8.238/macm1/26834/step_7.txt
>>
>> Error message is ld: file too small (length=8) file '/Users/thakis/src/llvm-project/clang/test/OpenMP/Inputs/libomp.a' for architecture arm64
>>
>> On the face of it I'd say that's a bug in your linker.
>
> It's just the standard Xcode linker, I didn't write it :)
>
>> The archive file is the magic `!<arch>\n` string by itself which is well formed to the extent the archive format is documented. It's definitely possible to put more text in the stub file to work around though it's hard to tell how much text, or whether your linker will do other validation like seeing whether the symbol table is present or objects actually contain machine code.
>>
>> I'm going to delete the test file in the meantime.
>> edit: or less aggressive, is there an UNSUPPORTED flag I can add that will drop it from your CI?
>
> Maybe you can pass an explicit `--target` triple to clang, and just check `-###` instead of actually linking, like driver tests usually do?

The point of the test is checking that the weirdness of rpath vs runpath combined with user specified flags works out properly after going through the linker so that would lose most (possibly all?) of the coverage.

The test may be more bother than it's worth though. I'll drop it for now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118493/new/

https://reviews.llvm.org/D118493