[Openmp-commits] [PATCH] D118399: [OpenMP] Only generate runtime flags with host input

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

In D118399#3277328 <https://reviews.llvm.org/D118399#3277328>, @ABataev wrote:

> Tests, if possible?

The flags being generated should be covered by an existing test, I'll add a line where we don't specify a bitcode library.

In D118399#3277357 <https://reviews.llvm.org/D118399#3277357>, @JonChesterfield wrote:

> There's an existing flag for compile for device only, that's probably close enough to the right condition to not emit these flags.

We already check that before entering this code block, both the runtime and host code use that flag so we can't differentiate with it alone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118399/new/

https://reviews.llvm.org/D118399