[Openmp-commits] [PATCH] D117807: [Libomptarget] Change visibility to hidden for device RTL

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

LG. @ronlieb rocm may need similar annotation for the old runtime, there's a macro for making variables externally accessible that would apply visibility protected to the environment and the array used by the memory allocator.



================
Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:27
 DeviceEnvironmentTy CONSTANT(omptarget_device_environment)
-    __attribute__((used, retain, weak));
+    __attribute__((used, retain, weak, visibility("default")));
 
----------------
Protected? Don't want to preempt this one either


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117807/new/

https://reviews.llvm.org/D117807