[Openmp-commits] [PATCH] D117715: [openmp] Always pass valid triple to openmp-targets when using newRTL

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

The libomptarget_target gets used as-is in two of the substitutions for forming an fopenmp-target string, and that variable was also used as a convenient way to run the tests under old and new rtl (the plugin/cuda and plugin/amdgpu cmake are responsible for enabling these tests and each appended both their normal triple and a second one with -newRTL appended as a way of switching on both tests, I've put a comment by the remainder of this.

All this comes under the heading of debt that disappears when we go back to using a single device runtime. In this particular instance, it's on me for (ab)using the triple string in that way from CMake without realising it was used like this by the test runner.



================
Comment at: openmp/libomptarget/test/lit.cfg:105
         config.test_flags += " --libomptarget-nvptx-bc-path=" + config.library_dir
     if config.libomptarget_current_target.endswith('-newRTL'):
         config.test_flags += " -fopenmp-target-new-runtime"
----------------
rest of hack here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117715/new/

https://reviews.llvm.org/D117715