[Openmp-commits] [PATCH] D116959: [DWARF] Try not to crash for codes with missing debug information
Johannes Doerfert via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Wed Jan 19 11:08:04 PST 2022
jdoerfert added a comment.
In D116959#3255632 <https://reviews.llvm.org/D116959#3255632>, @dblaikie wrote:
> In D116959#3255604 <https://reviews.llvm.org/D116959#3255604>, @jdoerfert wrote:
>> From the earlier comments I'm assuming this is good to go. I'll commit stuff later and intend to include this if I don't hear anything to the contrary
> Yep, sounds good to me. The DebugLoc on the load instruction is necessary, I take it? (I guess it could go on a ret instruction and have the @test function be void()?) That might point to another solution/direction - something is checking for debug locations, and maybe that something should be the one checking for DISubprogram on the function... *looks through the code* I don't immediately see where the existence of a !dbg on an instruction makes a difference here. (but simplified down the original godbolt to this: https://godbolt.org/z/dzGhPP51x and definitely removing the !dbg attachment for the instruction avoids the bug... )
I'll make it a single ret instruction with !dbg, that "works" (=crashes).
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits