[Openmp-commits] [PATCH] D117627: [OpenMP] Introduce an environment variable to disable atomic map clauses
Shilei Tian via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Wed Jan 19 08:07:40 PST 2022
tianshilei1992 added inline comments.
Comment at: openmp/docs/design/Runtimes.rst:1015
+consequence, users have to guarantee themselves that no two map clauses will
+concurrently map the same memory. If the memory is already mapped and the
+map clauses will only modify the reference counter from a non-zero count to
> tianshilei1992 wrote:
> > Probably better to mention no matter implicitly or explicitly.
> I don't get that. What to mention and how?
"As a consequence, users have to guarantee themselves that no two data mappings of same memory, explicitly through `map` clause or implicitly applied by compiler, will concurrently happen."
Comment at: openmp/docs/design/Runtimes.rst:686
+ * ``LIBOMPTARGET_MAP_FORCE_ATOMIC=[no, off, 0] (default on)``
> OpenMP spec use true/false, TRUE/FALSE. So better to keep the same convention. Values other than these four values should error out.
`libomp` supports all of them. Better to align with them.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits