[Openmp-commits] [PATCH] D117627: [OpenMP] Introduce an environment variable to disable atomic map clauses

[Ye Luo via Phabricator via Openmp-commits]

ye-luo requested changes to this revision.
ye-luo added inline comments.
This revision now requires changes to proceed.


================
Comment at: openmp/docs/design/Runtimes.rst:686
     * ``LIBOMPTARGET_SHARED_MEMORY_SIZE=<Num>``
+    * ``LIBOMPTARGET_MAP_FORCE_ATOMIC=[no, off, 0] (default on)``
 
----------------
OpenMP spec use true/false, TRUE/FALSE. So better to keep the same convention. Values other than these four values should error out.


================
Comment at: openmp/libomptarget/src/device.cpp:27
+  if (!PM->UseEventsForAtomicTransfers)
+    return OFFLOAD_SUCCESS;
+
----------------
unlock before return.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117627/new/

https://reviews.llvm.org/D117627