[Openmp-commits] [PATCH] D117627: [OpenMP] Introduce an environment variable to disable atomic map clauses

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: openmp/docs/design/Runtimes.rst:1015
+consequence, users have to guarantee themselves that no two map clauses will
+concurrently map the same memory. If the memory is already mapped and the
+map clauses will only modify the reference counter from a non-zero count to
----------------
Probably better to mention no matter implicitly or explicitly.


================
Comment at: openmp/libomptarget/include/device.h:212
+
+  /// Helper to make sure the entry is locked in a scope.
+  /// TODO: We should generalize this and use it for all our objects that use
----------------
That's a beautiful solution!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117627/new/

https://reviews.llvm.org/D117627