[Openmp-commits] [PATCH] D115966: [openmp][libomptarget][nfc] Infer types instead of duplicate and cast void

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:500
                             AsyncInfoTy &AsyncInfo) {
-  if (!RTL->run_region || !RTL->synchronize)
-    return RTL->run_region(RTLDeviceID, TgtEntryPtr, TgtVarsPtr, TgtOffsets,
-                           TgtVarsSize);
+  if (!RTL->run_target_region || !RTL->synchronize)
+    return RTL->run_target_region(RTLDeviceID, TgtEntryPtr, TgtVarsPtr,
----------------
JonChesterfield wrote:
> This (and three similar) pointers don't follow the pattern of plugin API with __tgt_rtl prefix removed, renamed them.
worth doing it in another patch


================
Comment at: openmp/libomptarget/src/rtl.h:83
+  init_device_ty init_device = nullptr;
   load_binary_ty *load_binary = nullptr;
+  data_alloc_ty data_alloc = nullptr;
----------------
`load_binary` is left.


================
Comment at: openmp/libomptarget/src/rtl.h:86
+  data_submit_ty data_submit = nullptr;
+  data_submit_async_ty data_submit_async = nullptr;
+  data_retrieve_ty data_retrieve = nullptr;
----------------
I think these changes also worth a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115966/new/

https://reviews.llvm.org/D115966