[Openmp-commits] [PATCH] D140810: [OpenMP][libomptarget] Add TargetParser as dependency in NextGen's JIT

[Kevin Sala Penadés via Phabricator via Openmp-commits]

kevinsala created this revision.
kevinsala added reviewers: tianshilei1992, jdoerfert.
kevinsala added a project: OpenMP.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
kevinsala requested review of this revision.
Herald added subscribers: openmp-commits, sstefan1.

This fixes an undefined symbol of `llvm::Triple::Triple()` constructor when building the NextGen plugins:

  /home/bsc15/bsc15572/scratch/llvm-project-patches/openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:343: undefined reference to `llvm::Triple::Triple(llvm::Twine const&)'

Although the patch makes the error to disappear on my side, I'm opening this review since I'm not 100% sure whether this is a complete fix.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140810

Files:
  openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt


Index: openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt
===================================================================
--- openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt
+++ openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt
@@ -49,6 +49,7 @@
     ScalarOpts
     Support
     Target
+    TargetParser
     TransformUtils
     Vectorize
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140810.485785.patch
Type: text/x-patch
Size: 422 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20221231/92e130d3/attachment.bin>