[Openmp-commits] [PATCH] D132676: [OpenMP][Fix] Track all threads that may delete an entry

[Ye Luo via Phabricator via Openmp-commits]

ye-luo accepted this revision.
ye-luo added inline comments.
This revision is now accepted and ready to land.


================
Comment at: openmp/libomptarget/src/device.cpp:369
+                         bool &IsHostPtr, bool MustContain, bool ForceDelete,
+                         bool FromDataEnd) {
   HDTTMapAccessorTy HDTTMap = HostDataToTargetMap.getExclusiveAccessor();
----------------
getTgtPtrBegin arguments are very correlated. Better to be scrutinized in the the future.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:893
         HstPtrBegin, DataSize, IsLast, UpdateRef, HasHoldModifier, IsHostPtr,
-        !IsImplicit, ForceDelete);
+        !IsImplicit, ForceDelete, FromDataEnd);
     void *TgtPtrBegin = TPR.TargetPointer;
----------------
More readable with
/*FromDataEnd=*/true



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132676/new/

https://reviews.llvm.org/D132676