[Openmp-commits] [PATCH] D132676: [OpenMP][Fix] Track all threads that may delete an entry

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

I have minor questions but after reading it once it seems to make sense.



================
Comment at: openmp/libomptarget/src/omptarget.cpp:760
+      FromMapperBase = HstPtrBegin;
+    }
 
----------------
What's this block about?


================
Comment at: openmp/libomptarget/src/omptarget.cpp:772
+    const bool IsLastUser = TPR.Entry->decDataEndThreadCount() != 0;
+    if (DelEntry && (TPR.Entry->getTotalRefCount() != 0 || IsLastUser)) {
+      // The thread is not in charge of deletion anymore. Give up access
----------------
IsNotLastUser, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132676/new/

https://reviews.llvm.org/D132676