[Openmp-commits] [PATCH] D140419: [OpenMP] Disable libomptarget integration on unsupported platforms

Tue Dec 20 11:30:10 PST 2022

gValarini marked 2 inline comments as done.
gValarini added inline comments.

================
Comment at: openmp/runtime/src/kmp_config.h.cmake:97
 #define KMP_HAVE__ALIGNED_MALLOC LIBOMP_HAVE__ALIGNED_MALLOC
+#cmakedefine01 OPENMP_ENABLE_LIBOMPTARGET
+#define ENABLE_LIBOMPTARGET OPENMP_ENABLE_LIBOMPTARGET
----------------
jhuber6 wrote:
> gValarini wrote:
> > jhuber6 wrote:
> > > Is this enough? We need to check the target OS, because even if the user builds on MacOS with `libomptarget` it won't always be included like if the user just passed `-fopenmp`.
> > If I am not mistaken, that is already checked on the OpenMP //CMakeLists.txt// file. `OPENMP_ENABLE_LIBOMPTARGET` can only be set to 1 if the target OS is not either macOS or Windows.
> > 
> > But do you think it would be better to tie that to something like `! (KMP_OS_WINDOWS || KMP_OS_DARWIN)`?
> You're right, forgot we did that check. It'll work for now and I guess we can revisit it if we ever want to lift that restriction.
Perfect! I'll land it then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140419/new/

https://reviews.llvm.org/D140419