[Openmp-commits] [PATCH] D139792: [OpenMP][libomptarget] Add utility header for AMDGPU plugins

Kevin Sala Penad├ęs via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Dec 14 15:28:56 PST 2022


kevinsala added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:21
+
+namespace llvm {
+namespace omp {
----------------
tschuett wrote:
> nested namespaces?
Could you add more context to the comment please? Are nested namespaces a problem? Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139792/new/

https://reviews.llvm.org/D139792



More information about the Openmp-commits mailing list