[Openmp-commits] [PATCH] D139116: [OpenMP] Refactoring: Move teams forking and serial region forking to separate functions.

[Jonathan Peyton via Phabricator via Openmp-commits]

jlpeyton added inline comments.


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:1357-1360
+#if (KMP_ARCH_X86_64 || KMP_ARCH_ARM || KMP_ARCH_AARCH64) && KMP_OS_LINUX
+                                          va_list *ap
+#else
+                                          va_list ap
----------------
This should be `kmp_va_list` instead of the `#ifdef`.


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:1371-1374
+#if (KMP_ARCH_X86_64 || KMP_ARCH_ARM || KMP_ARCH_AARCH64) && KMP_OS_LINUX
+                                           va_list *ap
+#else
+                                           va_list ap
----------------
Same


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:1392-1396
+#if (KMP_ARCH_X86_64 || KMP_ARCH_ARM || KMP_ARCH_AARCH64) && KMP_OS_LINUX
+                    va_list *ap
+#else
+                    va_list ap
+#endif
----------------
Same


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:1627-1632
+#if (KMP_ARCH_X86_64 || KMP_ARCH_ARM || KMP_ARCH_AARCH64) && KMP_OS_LINUX
+                       va_list *ap
+#else
+                       va_list ap
+#endif
+                       ) {
----------------
Same


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139116/new/

https://reviews.llvm.org/D139116