[Openmp-commits] [PATCH] D139792: [OpenMP][libomptarget] Add utility header for AMDGPU plugins

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:28
+// The implicit arguments of AMDGPU kernels.
+typedef struct impl_implicit_args_s {
+  uint64_t offset_x;
----------------
C++ style


================
Comment at: openmp/libomptarget/plugins/amdgpu/CMakeLists.txt:100
   ${CMAKE_CURRENT_SOURCE_DIR}/impl
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../plugins-nextgen/amdgpu/utils
 )
----------------
Not related to this patch, but I think we should really set a CMake variable for the header and use the variable instead of relative path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139792/new/

https://reviews.llvm.org/D139792