[Openmp-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.
Mark de Wever via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Sun Dec 11 11:15:42 PST 2022
Mordante marked an inline comment as done.
Mordante added a comment.
Thanks for all reviews!
In D137724#3974764 <https://reviews.llvm.org/D137724#3974764>, @thieta wrote:
> I think this is ready to land @Mordante or is there anything else missing?
No but I've been quite busy. I needed some time to find the list of buildbot owners to mail after landing this.
================
Comment at: clang/CMakeLists.txt:14
set(CLANG_BUILT_STANDALONE TRUE)
+ if ("${CMAKE_VERSION}" VERSION_LESS "3.20.0")
+ message(WARNING
----------------
mgorny wrote:
> I wonder if we could move this to `CMakePolicy.cmake`, though admittedly you'd have to somehow avoid warning multiple times in in-tree builds.
Yes I prefer to keep it this way. The warning will be removed once 3.20.0 or newer is mandated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137724/new/
https://reviews.llvm.org/D137724
More information about the Openmp-commits
mailing list