[Openmp-commits] [PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:228
+namespace jit {
+bool checkBitcodeImage(__tgt_device_image *Image, std::string Triple) {
+  TimeTraceScope TimeScope("Check bitcode image");
----------------
I might change the return value to `Expected<bool>` such that it is able to pass the error info back to caller.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139287/new/

https://reviews.llvm.org/D139287