[Openmp-commits] [PATCH] D138002: [OpenMP][libomptarget] Build plugins-nextgen/common/PluginInterface with protected visibility

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

In D138002#3969018 <https://reviews.llvm.org/D138002#3969018>, @tianshilei1992 wrote:

> In D138002#3969003 <https://reviews.llvm.org/D138002#3969003>, @jhuber6 wrote:
>
>> In D138002#3969000 <https://reviews.llvm.org/D138002#3969000>, @tianshilei1992 wrote:
>>
>>> Currently I'm still encountering the issue that, the function call to `__tgt_rtl_is_valid_binary` in `__tgt_rtl_is_valid_binary_info` jumps to another plugin.
>>
>> Can you check if that symbol is actually protected in the `.so` you're using?
>
> They are not protected.
>
>   ➜  readelf -s /home/ac.shilei.tian/Documents/build/openmp/debug/lib/libomptarget.rtl.x86_64.nextgen.so | rg is_va
>    77783: 000000000046b7b0   472 FUNC    GLOBAL DEFAULT   12 __tgt_rtl_is_val[...]
>    77866: 000000000046b710   157 FUNC    GLOBAL DEFAULT   12 __tgt_rtl_is_val[...]

Shows up protected for me

  > readelf -Ws ../../clang/lib/libomptarget.rtl.x86_64.nextgen.so | grep is_valid                                                                                              
     104: 000000000000d850    92 FUNC    GLOBAL PROTECTED   15 __tgt_rtl_is_valid_binary                                                                                                                                 
     113: 00000000000128f0   842 FUNC    GLOBAL PROTECTED   15 __tgt_rtl_is_valid_binary_info


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138002/new/

https://reviews.llvm.org/D138002