[Openmp-commits] [PATCH] D123974: [OpenMP] [OMPT] [3/8] Implemented callback registration in libomptarget

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

Looks like this patch breaks the build.

  FAILED: libomptarget/src/CMakeFiles/omptarget.dir/ompt_callback.cpp.o
  /home/ac.shilei.tian/Documents/build/llvm/release/bin/clang++ -DGTEST_HAS_RTTI=0 -DOMPTARGET_DEBUG -DOMPT_SUPPORT=1 -I/home/ac.shilei.tian/Documents/vscode/llvm-project/llvm/include -I/home/ac.shilei.tian/Documents/build/llvm/release/include -I/home/ac.shilei.tian/Documents/build/openmp/release/runtime/src -I/home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include -Wall -Wcast-qual -Wformat-pedantic -Wimplicit-fallthrough -Wsign-compare -Wno-enum-constexpr-conversion -Wno-extra -Wno-pedantic -std=c++17 -O3 -DNDEBUG -fPIC  -fno-exceptions -fno-rtti -MD -MT libomptarget/src/CMakeFiles/omptarget.dir/ompt_callback.cpp.o -MF libomptarget/src/CMakeFiles/omptarget.dir/ompt_callback.cpp.o.d -o libomptarget/src/CMakeFiles/omptarget.dir/ompt_callback.cpp.o -c /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/src/ompt_callback.cpp
  In file included from /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/src/ompt_callback.cpp:22:
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/ompt_device_callbacks.h:45:34: error: use of undeclared identifier 'DEBUG_PREFIX'
      FOREACH_OMPT_TARGET_CALLBACK(OmptBindCallback);
                                   ^
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/ompt_device_callbacks.h:45:34: error: use of undeclared identifier 'DEBUG_PREFIX'
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/ompt_device_callbacks.h:45:34: error: use of undeclared identifier 'DEBUG_PREFIX'
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/ompt_device_callbacks.h:45:34: error: use of undeclared identifier 'DEBUG_PREFIX'
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/ompt_device_callbacks.h:45:34: error: use of undeclared identifier 'DEBUG_PREFIX'
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/ompt_device_callbacks.h:45:34: error: use of undeclared identifier 'DEBUG_PREFIX'
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/ompt_device_callbacks.h:45:34: error: use of undeclared identifier 'DEBUG_PREFIX'
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/ompt_device_callbacks.h:45:34: error: use of undeclared identifier 'DEBUG_PREFIX'
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/ompt_device_callbacks.h:45:34: error: use of undeclared identifier 'DEBUG_PREFIX'
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/ompt_device_callbacks.h:45:34: error: use of undeclared identifier 'DEBUG_PREFIX'
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/ompt_device_callbacks.h:45:34: error: use of undeclared identifier 'DEBUG_PREFIX'
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/ompt_device_callbacks.h:45:34: error: use of undeclared identifier 'DEBUG_PREFIX'
  12 errors generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123974/new/

https://reviews.llvm.org/D123974