[Openmp-commits] [PATCH] D123974: [OpenMP] [OMPT] [3/8] Implemented callback registration in libomptarget

[Jan-Patrick Lehr via Phabricator via Openmp-commits]

jplehr added a comment.

My comment about the naming applies to all objects / variables etc.
I'm unsure whether it would help readability, but I have in mind that it makes the external/user-facing API clearly distinguishable from the internal one.



================
Comment at: openmp/libomptarget/include/ompt_device_callbacks.h:60
+/// Device callbacks object for the library that performs the instantiation
+extern OmptDeviceCallbacksTy ompt_device_callbacks;
+
----------------
I wonder if we should limit the use of snake_case to only the OMP/OMPT interface functions and types, and stick with the LLVM naming conventions otherwise?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123974/new/

https://reviews.llvm.org/D123974