[Openmp-commits] [PATCH] D133053: [Libomptarget] Change device free routines to accept the allocation kind

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/include/device.h:410
+  /// allocator should be used (host, shared, device).
+  int32_t deleteData(void *TgtPtrBegin, int32_t Kind = TARGET_ALLOC_DEFAULT);
 
----------------
JonChesterfield wrote:
> Might be better to avoid the default argument here in favour of explicit at call site since that'll help pair up allocation kind when reading the implementation. Probably as a follow up patch to this one since the verbosity would detract from the review.
The alloc above does the same default argument so it made sense to just copy it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133053/new/

https://reviews.llvm.org/D133053